scverse / mudata

Multimodal Data (.h5mu) implementation for Python

https://mudata.rtfd.io

BSD 3-Clause "New" or "Revised" License

72 stars 17 forks source link

anndata 0.8 compat #8

Closed ivirshup closed 2 years ago

ivirshup commented 2 years ago

This is a draft PR which aiming to make mudata compatible with anndata 0.8. Ideally it will also be compatible with 0.7 and will have as few changes as possible.

ivirshup commented 2 years ago

lol, maybe point me at a trivial change to make so I can get CI here

ivirshup commented 2 years ago

Some of the stuff from #7 is going to get broken by https://github.com/theislab/anndata/pull/554, which I think I'll merge tomorrow. Hopefully no release has been made? I think it'd make sense to only release with that once the next anndata release is out.

gtca commented 2 years ago

Thanks for the heads-up, I expect we'll have 0.1.2 (0.2.0?) with anndata >=0.8 then.

codecov-commenter commented 2 years ago

Codecov Report

Merging #8 (7a0298b) into master (1d0b4ae) will increase coverage by 1.07%. The diff coverage is 76.92%.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   67.12%   68.20%   +1.07%     
==========================================
  Files          12       12              
  Lines        1451     1434      -17     
==========================================
+ Hits          974      978       +4     
+ Misses        477      456      -21

Impacted Files	Coverage Δ
mudata/_core/io.py	`70.05% <76.56%> (+4.40%)`	:arrow_up:
mudata/__init__.py	`100.00% <100.00%> (ø)`

gtca commented 2 years ago

@ivirshup Seems to work now, both with HDF5 and Zarr. In case you might want to take a look if there are no glaring omissions.