Open ilan-gold opened 2 months ago
@ilan-gold singledispatch and and docs dont work together with gpu arrays. I have no Idea why that is. To get docs to run I had to refactor normalize_total not to use it. If you figure out how docs will run with this we can talk about it some more.
I added a separate file here containing the refactor. It drops the number of lines by 50, and that's only first pass (second would be more).
To reproduce my benchmark, I ran (on our current cluster setup):
and then the following script in a file called
rsc_example.py
viapython rsc_example.py refactored
orpython rsc_example.py current
. This script prints out the time taken and theAnnData
object (so one can see the QC is calculated). For me, I get about 800-900 milliseconds on both implementations.