Update Marsilea example notebook

[Mr-Milk]

• Given the API updates from hsplit/vsplit -> group_rows/group_cols in Marsilea, @ivirshup has updated the API usage. I then updated the text description.
• Add an example for tracksplot (With marsilea >= 0.3.4).
• Add an example for stacked violin plot.

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[ivirshup]

Any chance this could be a little nicer? I think a rotation of the label could be more readable.

This is getting a little fancier, but could you also remove the updates for pngs which don't seem to actually be changing?

[Mr-Milk]

Sure the label can be rotated.

I'm not sure how to remove the updated picture, the notebook store image in base64, if I rerun the notebook the image encoding will be different even though the image look the same. Do you have any idea how to do it?

[flying-sheep]

There’s no real way other than manually discarding these changes (Some diff editors such as VS Code’s as of last release can discard a single change instead of the whole file)

But don’t worry about it. Once things get too big, people can always do git clone --filter=blob:none to skip downloading old files.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

flying-sheep commented on 2024-04-25T08:59:34Z ----------------------------------------------------------------

The group_rows can group heatmap by group labels

Should be “The group_rows method can …” or “group_rows can …”

the order define the display order of each cell types

“defines” and either “of each cell type” or “of cell types”

review-notebook-app[bot] commented 7 months ago

View / edit / reply to this conversation on ReviewNB

flying-sheep commented on 2024-04-25T08:59:35Z ----------------------------------------------------------------

As Isaac said, would be great to rotate the labels.

Ideally all that fit by 90 deg, and the ones that are close together by 45 deg, but rotating all by 45 deg would also work I think.

Mr-Milk commented on 2024-04-26T08:46:46Z ----------------------------------------------------------------

I've change the labels on the right side, do you mean rotate these labels or the axis labels for numbers?

Mr-Milk commented 7 months ago

I've change the labels on the right side, do you mean rotate these labels or the axis labels for numbers?

---

View entire conversation on ReviewNB

flying-sheep commented 7 months ago

Ah, maybe he meant the side labels, which were actually unreadable before. I referred to the bottom labels, which are readable, but take up more space than necessary. But not necessary.

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

flying-sheep commented on 2024-04-25T08:59:35Z ----------------------------------------------------------------

As Isaac said, would be great to rotate the labels.

Ideally all that fit by 90 deg, and the ones that are close together by 45 deg, but rotating all by 45 deg would also work I think.

Mr-Milk commented on 2024-04-26T08:46:46Z ----------------------------------------------------------------

I've change the labels on the right side, do you mean rotate these labels or the axis labels for numbers?

Mr-Milk commented 7 months ago

I've change the labels on the right side, do you mean rotate these labels or the axis labels for numbers?

---

View entire conversation on ReviewNB

flying-sheep commented 7 months ago

Ah, maybe he meant the side labels, which were actually unreadable before. I referred to the bottom labels, which are readable, but take up more space than necessary. But not necessary.

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[Mr-Milk]

I've change the labels on the right side, do you mean rotate these labels or the axis labels for numbers?

---

View entire conversation on ReviewNB

[flying-sheep]

Ah, maybe he meant the side labels, which were actually unreadable before. I referred to the bottom labels, which are readable, but take up more space than necessary. But not necessary.