scverse / scanpy-tutorials

Scanpy Tutorials.
https://scanpy-tutorials.readthedocs.io/
189 stars 117 forks source link

advanced plotting #61

Closed Hrovatin closed 1 year ago

Hrovatin commented 1 year ago

Advanced plotting tutorial

Note: Contains matplotlib specific functions/objects and some external packages (outside of Scanpy)

Closes https://github.com/scverse/scverse-tutorials/issues/25

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

namsaraeva commented on 2022-12-09T14:49:38Z ----------------------------------------------------------------

continuous*

multiple*


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

namsaraeva commented on 2022-12-09T14:49:39Z ----------------------------------------------------------------

Line #14.    print('\nContinuous plots:')


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

Zethson commented on 2023-02-21T12:27:19Z ----------------------------------------------------------------

Line #1.    # Load PBMC dataset

Think we can remove this comment. You can add a comment about the dataset though.


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

Zethson commented on 2023-02-21T12:27:20Z ----------------------------------------------------------------

This section provides general information on how to customize plots.

That's what the title of the section already says. I'd replace this sentence with the goal of this section or so.

in trun

in turn


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

Zethson commented on 2023-02-21T12:27:21Z ----------------------------------------------------------------

You can also use markdown notes to render this nicely if you want to.

> **_NOTE:_**  The note content.


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

Zethson commented on 2023-02-21T12:27:22Z ----------------------------------------------------------------

IMO you also need to mention scanpy's setting here which is a wrapper of the rcParams


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

Zethson commented on 2023-02-21T12:27:23Z ----------------------------------------------------------------

You're looking for the Python language concept "contextmanager". I'd use it here.


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

Zethson commented on 2023-02-21T12:27:24Z ----------------------------------------------------------------

Line #1.    # Compute PAGA

You can remove this I guess