search

scverse / scanpy-tutorials

Scanpy Tutorials.
https://scanpy-tutorials.readthedocs.io/
189 stars 117 forks source link

Use sklearn-ann in "alternative knn libraries" tutorial? #90

Closed ivirshup closed 8 months ago

ivirshup commented 8 months ago

@flying-sheep, should we point out (and maybe use) sklearn-ann in the tutorial you added?

ivirshup commented 8 months ago

I feel like the definition of the Annoy class should go into the docs for sklearn-ann either way

flying-sheep commented 8 months ago

It’s mentioned and linked twice. I didn’t directly use it because that way it’s easier to explain how the class has to look.

I feel like the definition of the Annoy class should go into the docs for sklearn-ann either way

I don’t think that makes sense: our API demands get_params and fit_transform. sklearn-ann happens to provide both of these and more in all the classes it defines. Its docs are complete.

I’ll leave this open so we can add an usage example for sklearn-ann once it’s on PyPI.