Closed flying-sheep closed 1 month ago
Attention: Patch coverage is 25.00000%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 76.75%. Comparing base (
bd75839
) to head (c06bbc8
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/scanpy/plotting/_stacked_violin.py | 25.00% | 3 Missing :warning: |
The tests use
group
but the code handlesobs
TODO: should
heatmap
be changed too? Its docs actually speak of “variables or observations” and not “variables or groups”About the test changes:
Some time ago, matplotlib made a change to font rendering. Since we have such high tolerance when comparing plots, that didn’t affect our tests. But that also means that our tests are almost useless, since the actual qualitative difference in the test that did change behavior due to my PR wasn’t caught. Therefore I lowered the tolerance, which meant I had to regenerate everything with the new font rendering.