scverse / scanpy

Single-cell analysis in Python. Scales to >1M cells.
https://scanpy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.92k stars 602 forks source link

Backport PR #3249 on branch 1.10.x (Clean up dendrogram typing) #3251

Closed meeseeksmachine closed 1 month ago

meeseeksmachine commented 1 month ago

Backport PR #3249: Clean up dendrogram typing

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.71%. Comparing base (b325b50) to head (408a7b5). Report is 1 commits behind head on 1.10.x.

Files with missing lines Patch % Lines
src/scanpy/plotting/_anndata.py 93.10% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 1.10.x #3251 +/- ## ========================================== - Coverage 76.72% 76.71% -0.01% ========================================== Files 109 109 Lines 12536 12541 +5 ========================================== + Hits 9618 9621 +3 - Misses 2918 2920 +2 ``` | [Flag](https://app.codecov.io/gh/scverse/scanpy/pull/3251/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/scverse/scanpy/pull/3251/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse) | `74.20% <94.59%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/scverse/scanpy/pull/3251?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse) | Coverage Δ | | |---|---|---| | [src/scanpy/plotting/\_baseplot\_class.py](https://app.codecov.io/gh/scverse/scanpy/pull/3251?src=pr&el=tree&filepath=src%2Fscanpy%2Fplotting%2F_baseplot_class.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NjYW5weS9wbG90dGluZy9fYmFzZXBsb3RfY2xhc3MucHk=) | `90.30% <100.00%> (ø)` | | | [src/scanpy/plotting/\_dotplot.py](https://app.codecov.io/gh/scverse/scanpy/pull/3251?src=pr&el=tree&filepath=src%2Fscanpy%2Fplotting%2F_dotplot.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NjYW5weS9wbG90dGluZy9fZG90cGxvdC5weQ==) | `92.24% <100.00%> (ø)` | | | [src/scanpy/plotting/\_matrixplot.py](https://app.codecov.io/gh/scverse/scanpy/pull/3251?src=pr&el=tree&filepath=src%2Fscanpy%2Fplotting%2F_matrixplot.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NjYW5weS9wbG90dGluZy9fbWF0cml4cGxvdC5weQ==) | `96.70% <100.00%> (ø)` | | | [src/scanpy/plotting/\_stacked\_violin.py](https://app.codecov.io/gh/scverse/scanpy/pull/3251?src=pr&el=tree&filepath=src%2Fscanpy%2Fplotting%2F_stacked_violin.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NjYW5weS9wbG90dGluZy9fc3RhY2tlZF92aW9saW4ucHk=) | `83.90% <100.00%> (ø)` | | | [src/scanpy/plotting/\_utils.py](https://app.codecov.io/gh/scverse/scanpy/pull/3251?src=pr&el=tree&filepath=src%2Fscanpy%2Fplotting%2F_utils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NjYW5weS9wbG90dGluZy9fdXRpbHMucHk=) | `56.64% <100.00%> (+0.16%)` | :arrow_up: | | [src/scanpy/plotting/\_anndata.py](https://app.codecov.io/gh/scverse/scanpy/pull/3251?src=pr&el=tree&filepath=src%2Fscanpy%2Fplotting%2F_anndata.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NjYW5weS9wbG90dGluZy9fYW5uZGF0YS5weQ==) | `84.89% <93.10%> (-0.16%)` | :arrow_down: |