Open flying-sheep opened 3 days ago
this PR
moves _pca_with_sparse behind a check for scipy <1.4, which has @ivirshup’s port of that code https://github.com/scikit-learn/scikit-learn/pull/18689
_pca_with_sparse
simplifies our logic around which parameters lead to which dispatch
this makes it useful to get this in before #3263
throws a warning when people use the lobpcg solver, since the closure of https://github.com/scikit-learn/scikit-learn/issues/12794#issuecomment-2118064158 makes it unlikely that we can count on that getting in any time soon
lobpcg
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.04%. Comparing base (48706ca) to head (1a1a396).
48706ca
1a1a396
this PR
moves
_pca_with_sparse
behind a check for scipy <1.4, which has @ivirshup’s port of that code https://github.com/scikit-learn/scikit-learn/pull/18689simplifies our logic around which parameters lead to which dispatch
this makes it useful to get this in before #3263
throws a warning when people use the
lobpcg
solver, since the closure of https://github.com/scikit-learn/scikit-learn/issues/12794#issuecomment-2118064158 makes it unlikely that we can count on that getting in any time soon