search

scverse / scanpy

Single-cell analysis in Python. Scales to >1M cells.
https://scanpy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.93k stars 603 forks source link

Fix PCA tests #3336

Closed flying-sheep closed 3 weeks ago

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.22%. Comparing base (dda1f6e) to head (c4a1e0a). Report is 5 commits behind head on ig/fix_pca_args.

Files with missing lines Patch % Lines
src/scanpy/_utils/__init__.py 83.33% 2 Missing :warning:
src/scanpy/get/_aggregated.py 75.00% 1 Missing :warning:
src/scanpy/tools/_draw_graph.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## ig/fix_pca_args #3336 +/- ## =================================================== + Coverage 77.21% 77.22% +0.01% =================================================== Files 111 111 Lines 12597 12604 +7 =================================================== + Hits 9727 9734 +7 Misses 2870 2870 ``` | [Files with missing lines](https://app.codecov.io/gh/scverse/scanpy/pull/3336?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse) | Coverage Δ | | |---|---|---| | [src/scanpy/neighbors/\_\_init\_\_.py](https://app.codecov.io/gh/scverse/scanpy/pull/3336?src=pr&el=tree&filepath=src%2Fscanpy%2Fneighbors%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NjYW5weS9uZWlnaGJvcnMvX19pbml0X18ucHk=) | `81.06% <100.00%> (ø)` | | | [src/scanpy/neighbors/\_types.py](https://app.codecov.io/gh/scverse/scanpy/pull/3336?src=pr&el=tree&filepath=src%2Fscanpy%2Fneighbors%2F_types.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NjYW5weS9uZWlnaGJvcnMvX3R5cGVzLnB5) | `100.00% <ø> (ø)` | | | [src/scanpy/plotting/\_anndata.py](https://app.codecov.io/gh/scverse/scanpy/pull/3336?src=pr&el=tree&filepath=src%2Fscanpy%2Fplotting%2F_anndata.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NjYW5weS9wbG90dGluZy9fYW5uZGF0YS5weQ==) | `85.56% <100.00%> (-0.02%)` | :arrow_down: | | [src/scanpy/preprocessing/\_pca/\_\_init\_\_.py](https://app.codecov.io/gh/scverse/scanpy/pull/3336?src=pr&el=tree&filepath=src%2Fscanpy%2Fpreprocessing%2F_pca%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NjYW5weS9wcmVwcm9jZXNzaW5nL19wY2EvX19pbml0X18ucHk=) | `91.91% <100.00%> (+1.10%)` | :arrow_up: | | [src/scanpy/tools/\_rank\_genes\_groups.py](https://app.codecov.io/gh/scverse/scanpy/pull/3336?src=pr&el=tree&filepath=src%2Fscanpy%2Ftools%2F_rank_genes_groups.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NjYW5weS90b29scy9fcmFua19nZW5lc19ncm91cHMucHk=) | `94.50% <100.00%> (-0.02%)` | :arrow_down: | | [src/scanpy/get/\_aggregated.py](https://app.codecov.io/gh/scverse/scanpy/pull/3336?src=pr&el=tree&filepath=src%2Fscanpy%2Fget%2F_aggregated.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NjYW5weS9nZXQvX2FnZ3JlZ2F0ZWQucHk=) | `95.23% <75.00%> (ø)` | | | [src/scanpy/tools/\_draw\_graph.py](https://app.codecov.io/gh/scverse/scanpy/pull/3336?src=pr&el=tree&filepath=src%2Fscanpy%2Ftools%2F_draw_graph.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NjYW5weS90b29scy9fZHJhd19ncmFwaC5weQ==) | `65.00% <75.00%> (-0.58%)` | :arrow_down: | | [src/scanpy/\_utils/\_\_init\_\_.py](https://app.codecov.io/gh/scverse/scanpy/pull/3336?src=pr&el=tree&filepath=src%2Fscanpy%2F_utils%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NjYW5weS9fdXRpbHMvX19pbml0X18ucHk=) | `75.51% <83.33%> (-0.01%)` | :arrow_down: |
flying-sheep commented 3 weeks ago

we need to finally fix that CI failure in this job, I only look into the minimum_versions job anymore before I merge PRs