search

scverse / scvi-tools

Deep probabilistic analysis of single-cell and spatial omics data
http://scvi-tools.org/
BSD 3-Clause "New" or "Revised" License
1.16k stars 341 forks source link

feat(autotune): add support for ray 2.24 #2831

Closed martinkim0 closed 3 weeks ago

martinkim0 commented 3 weeks ago

ray 2.24 apparently removed the local_dir argument from RunConfig, which should now be equivalent to storage_path (we were specifying both arguments as settings.logging_dir before). this commit just removes the local_dir argument on our end from autotune.Experiment.

see https://github.com/scverse/scvi-tools/actions/runs/9435814911/job/25989750995 for an example failure.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.22%. Comparing base (d58f419) to head (3b33c48).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2831 +/- ## ========================================== - Coverage 85.24% 85.22% -0.03% ========================================== Files 166 166 Lines 14236 14236 ========================================== - Hits 12136 12133 -3 - Misses 2100 2103 +3 ``` | [Files](https://app.codecov.io/gh/scverse/scvi-tools/pull/2831?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse) | Coverage Δ | | |---|---|---| | [src/scvi/autotune/\_experiment.py](https://app.codecov.io/gh/scverse/scvi-tools/pull/2831?src=pr&el=tree&filepath=src%2Fscvi%2Fautotune%2F_experiment.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NjdmkvYXV0b3R1bmUvX2V4cGVyaW1lbnQucHk=) | `89.38% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/scverse/scvi-tools/pull/2831/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse)