Open ori-kron-wis opened 1 month ago
Attention: Patch coverage is 97.82609%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 84.35%. Comparing base (
795297e
) to head (77df3e2
).
Files with missing lines | Patch % | Lines |
---|---|---|
src/scvi/nn/_base_components.py | 95.00% | 2 Missing :warning: |
This kind of change requires touching the module for each model. I don't think there is anywhere around it. Its risky and this is why I implemented it only for scvi & scanvi at the moment (maybe others will work also but I didn't test thoroughly). the rest of the changed modules are mainly things in function headers and placeholders to able to cope with the major changes in base_components (i.e cont_cov is usually None and cant be injected to their hidden layers).
To summarise we have 2 parameters to think of:
@Hrovatin please try to use this branch
@ori-kron-wis I think there are things that need to be fixed as per my review comments. To summarise: I think the behaviour should be as follows:
@canergen can you confirm?
Added other covariates types (continuous, embedded) to be able to reinjected, and not just to the input layer