Open kevinyamauchi opened 1 year ago
Would this be coherent with the syntax from other parts of the package? I'm not super aware of the other modules but is the syntax right now
sdata
.pp.get_bb()
.pp.query()
or
sdata
.pp
.get_bb()
.query()
?
I'm sure we could find a way in which we'd only need to call the plot accessor once, but I'd prefer not to implement sth that could raise the question "when and how many pl
, pp
etc do I need?"
Related also to this https://github.com/scverse/spatialdata/issues/225, we need to discuss some more uniform names/syntax. We could do this next week at the hackathon.
Description of feature
Thanks for the super nice work, @timtreis and @sagar87 ! I think it would be nice if we didn't have to add intermediate calls to
pl
when chaining renderers. That is, I think it would be nice if instead of this:We could do this:
This perhaps could be possible if the
render_*()
methods returned the plot accessor instead of theSpatialData
object. I suppose this means that one couldn't do app
operation after apl
operation, but maybe that suggests thepl
andpp
operations should be on the same level of the hierarchy or one should do their preprocessing first, then their plotting. I'm not sure what's best here, but it might be good to experiment with this once all of the p0 functionality is finished.