search

scverse / spatialdata

An open and interoperable data framework for spatial omics data
https://spatialdata.scverse.org/
BSD 3-Clause "New" or "Revised" License
186 stars 34 forks source link

Support remote private storage by consistent use of substore #442

Open berombau opened 4 months ago

berombau commented 4 months ago

Closes #441, depends on (https://github.com/ome/ome-zarr-py/pull/349)

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 92.52%. Comparing base (b73f3a8) to head (7bb87ba). Report is 2 commits behind head on main.

:exclamation: Current head 7bb87ba differs from pull request most recent head c120a4d. Consider uploading reports for the commit c120a4d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #442 +/- ## ========================================== - Coverage 92.53% 92.52% -0.02% ========================================== Files 43 39 -4 Lines 6003 5270 -733 ========================================== - Hits 5555 4876 -679 + Misses 448 394 -54 ``` | [Files](https://app.codecov.io/gh/scverse/spatialdata/pull/442?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse) | Coverage Δ | | |---|---|---| | [src/spatialdata/\_core/spatialdata.py](https://app.codecov.io/gh/scverse/spatialdata/pull/442?src=pr&el=tree&filepath=src%2Fspatialdata%2F_core%2Fspatialdata.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NwYXRpYWxkYXRhL19jb3JlL3NwYXRpYWxkYXRhLnB5) | `94.43% <ø> (+2.21%)` | :arrow_up: | | [src/spatialdata/\_io/io\_raster.py](https://app.codecov.io/gh/scverse/spatialdata/pull/442?src=pr&el=tree&filepath=src%2Fspatialdata%2F_io%2Fio_raster.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NwYXRpYWxkYXRhL19pby9pb19yYXN0ZXIucHk=) | `96.29% <100.00%> (ø)` | | | [src/spatialdata/\_io/io\_shapes.py](https://app.codecov.io/gh/scverse/spatialdata/pull/442?src=pr&el=tree&filepath=src%2Fspatialdata%2F_io%2Fio_shapes.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NwYXRpYWxkYXRhL19pby9pb19zaGFwZXMucHk=) | `100.00% <100.00%> (+2.04%)` | :arrow_up: | | [src/spatialdata/\_io/io\_zarr.py](https://app.codecov.io/gh/scverse/spatialdata/pull/442?src=pr&el=tree&filepath=src%2Fspatialdata%2F_io%2Fio_zarr.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NwYXRpYWxkYXRhL19pby9pb196YXJyLnB5) | `86.08% <66.66%> (-2.29%)` | :arrow_down: | ... and [22 files with indirect coverage changes](https://app.codecov.io/gh/scverse/spatialdata/pull/442/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse)
giovp commented 1 month ago

for some reason it didn't rebase to main...