Closed ArneDefauw closed 1 month ago
Hi @ArneDefauw, thanks for the contribution. Is this still in draft mode? If so, what's missing? Thanks!
I changed status of PR, there is not really something missing, but for points, there still seem to be issues with workaround 2 ,as suggested, I am not sure if this is expected or not...
Thanks for reporting and for the code. The use case of wanting to overwrite lazy data is an important one and now this is considered in tests. For clarify, I have split the test into 4 subcases: workaround 1 and 2, and lazy vs non-lazy data. In this way the user can see which case to use and have some code to start with.
A few more comments:
xarray.DataArray
doesn't throw an error when it tries to load from the Zarr store that had been deleted, but if you compute the data you will see that the tensor is now a tensor of zeros.
update unit test incremental io on disk, see https://github.com/scverse/spatialdata/pull/501#issuecomment-2016568527