search

scverse / spatialdata

An open and interoperable data framework for spatial omics data
https://spatialdata.scverse.org/
BSD 3-Clause "New" or "Revised" License
174 stars 34 forks source link

drop unmaintained pygeos for shapely 2.0 #545

Open omsai opened 4 weeks ago

omsai commented 4 weeks ago

The requirement pygeos fails to install with python 3.12 with the error described here: https://github.com/pygeos/pygeos/issues/463

The maintainer explains that pygeos is no longer maintained and has been merged into the shapley 2.0 dependency of geopandas. Since version 0.14, geopandas uses shapley instead of pygeos: https://geopandas.org/en/stable/docs/user_guide/pygeos_to_shapely.html

Therefore, the PR drops the unmaintained pygeos and requires geopandas >= 0.14 to ensure the default shapley version is used instead.

clwgg commented 4 weeks ago

(Issue tracked here: #432)

giovp commented 3 weeks ago

thanks @omsai for this PR, I wonder we could probably also remove this right https://github.com/scverse/spatialdata/blob/main/src/spatialdata/_compat.py#L1 ?

omsai commented 3 weeks ago

@giovp Indeed; I've dropped that as well.

giovp commented 3 weeks ago

thank you @omsai , I think it should be fine to not have it backward compatible, would like to have other devs chime in