scverse / spatialdata

An open and interoperable data framework for spatial omics data
https://spatialdata.scverse.org/
BSD 3-Clause "New" or "Revised" License
237 stars 45 forks source link

Use numba jit instead of njit to remove warning #767

Closed quentinblampey closed 1 week ago

quentinblampey commented 2 weeks ago

One-character PR to remove the following warning during the import of spatialdata:

RuntimeWarning: nopython is set for njit and is ignored

Very minor PR, not urgent. See here the difference between numba.jit and numba.njit.

I was annoyed about this warning when running segmentation: for instance, with 50 workers, the warning gets duplicated 50 times and breaks the progress bar.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.85%. Comparing base (a89d16d) to head (725c7c1). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #767 +/- ## ======================================= Coverage 91.85% 91.85% ======================================= Files 45 45 Lines 6885 6885 ======================================= Hits 6324 6324 Misses 561 561 ``` | [Files with missing lines](https://app.codecov.io/gh/scverse/spatialdata/pull/767?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse) | Coverage Δ | | |---|---|---| | [src/spatialdata/\_core/query/\_utils.py](https://app.codecov.io/gh/scverse/spatialdata/pull/767?src=pr&el=tree&filepath=src%2Fspatialdata%2F_core%2Fquery%2F_utils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL3NwYXRpYWxkYXRhL19jb3JlL3F1ZXJ5L191dGlscy5weQ==) | `84.21% <100.00%> (ø)` | |