Closed melonora closed 1 week ago
Attention: Patch coverage is 88.88889%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 91.84%. Comparing base (
42f7b6a
) to head (088dec2
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/spatialdata/models/models.py | 88.88% | 1 Missing :warning: |
still need to see how we can have c_coords
only in docstring when dealing with images and not labels.
still need to see how we can have c_coords only in docstring when dealing with images and not labels.
Does this work now?
Btw, looks great, pre-approving. Only missing thing, please add some tests (testing that it works for images and testing that it gives an error for labels, and for images when there is a mismatch). Then feel free to merge, thanks!
Main problem is that the docstring must be a literal so you can't use f strings or anything.
This PR implements one of the tasks in #750 to improve the handling of channel names. It moves the
c_coords
parameter out of kwargs and also adds a validation for a mismatch in length betweenc_coords
and the length of thec
dimension.