scverse / squidpy_notebooks

Tutorials for Squidpy
https://squidpy.readthedocs.io/en/stable/
MIT License
28 stars 17 forks source link

Updated the quality control plots #110

Closed pakiessling closed 1 year ago

pakiessling commented 1 year ago

To show in how many different cells individual genes are expressed.

Discussed in https://github.com/scverse/squidpy/issues/629

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

giovp commented 1 year ago

fantastic work @pakiessling ! this is very useful contribution and I'm sure it'll make it easier for users to understand this type of pre-processing.

In case you feel like it's doable, would you consider updating the same plot for the nanostring vignette? The file in your fork is here https://github.com/pakiessling/squidpy_notebooks/blob/merfish_tutorial/docs/source/external_tutorials/tutorial_nanostring.ipynb

let me know and in case you rather skip it I'll merge this PR right away.

Thanks a lot for this contribution!

pakiessling commented 1 year ago

@giovp Sure I can give nanostrings a shot.

In general I have some Ideas on how I could improve the tutorials, if you would be up for that.

Change the deprecated sns.distplot to sns.histplot, explain the QC process a bit more, add some more details and references for Centrality score ect...

giovp commented 1 year ago

that sounds fantastic! I'd be really curious to see these type of improvements, please go ahead! You could do it here, or on a separate PR as you wish. If you'd like to chat more or asking anything specific I'd also suggest to join our scverse zulip (see link here https://scverse.org/join/ ).

giovp commented 1 year ago

hi @pakiessling , we are planning to have new release next month and I'd love to include these types of improvements in 1.3.0 , let me know if you are still interested otherwise no problem we'll include this as is!

pakiessling commented 1 year ago

@giovp Hi Giovanni, I am currently on holiday, but will be back & focusing on this next week. I am very interested in improving the documentation further.

I know most about Merfish, since this is the technology I have access too, but I assume at least the QC steps will be similar for other technologies?

giovp commented 1 year ago

@pakiessling any update on this? we are in full swing for new release and we'd like to include some of these changes. @LLehner is doing some notebooks conversions to ease up current notebooks CI. Let me know if the above mentioned are still in scope for you and otherwise would go on and merge this as is and you can push changes to another PR.

pakiessling commented 1 year ago

Hi Giovanni, sorry about this. I am unfortunately stuck in Corona Quarantine without access to my work Pc. Let’s just stay with this PR for now.

I will open another PR for further improvements when I get back to work.

From: Giovanni Palla @.> Reply to: scverse/squidpy_notebooks @.> Date: Friday, 17. February 2023 at 08:39 To: scverse/squidpy_notebooks @.> Cc: "Kießling, Paul" @.>, Mention @.***> Subject: Re: [scverse/squidpy_notebooks] Updated the quality control plots (PR #110)

@pakiesslinghttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpakiessling&data=05%7C01%7C%7Cfeef6c86c77a4a7f5be808db10ba182b%7C5a6d5ee56edf4a26ba93f5872dbb9614%7C0%7C0%7C638122163681002644%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=FsbFwnlSbG%2BioWHAaVXxXBMcFKm2n1uCeSXjuuKeKlo%3D&reserved=0 any update on this? we are in full swing for new release and we'd like to include some of these changes. @LLehnerhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLLehner&data=05%7C01%7C%7Cfeef6c86c77a4a7f5be808db10ba182b%7C5a6d5ee56edf4a26ba93f5872dbb9614%7C0%7C0%7C638122163681002644%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=W7Dye5xtlPeSM8rylW%2F%2BslJ2qTJPSQRPIWM0nHE59aY%3D&reserved=0 are doing some notebooks conversions to ease up current notebooks CI. Let me know if the above mentioned are still in scope for you and otherwise would go on and merge this as is and you can push changes to another PR.

— Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fscverse%2Fsquidpy_notebooks%2Fpull%2F110%23issuecomment-1434247463&data=05%7C01%7C%7Cfeef6c86c77a4a7f5be808db10ba182b%7C5a6d5ee56edf4a26ba93f5872dbb9614%7C0%7C0%7C638122163681002644%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=u4qIA%2F%2BTHk3EVJaTj4AGg6xwxOXPGEKO7KYepZ6tdKU%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAY75ZTWVQZVQNTJ3PIUGLSLWX4TKZANCNFSM6AAAAAAUGEJ3D4&data=05%7C01%7C%7Cfeef6c86c77a4a7f5be808db10ba182b%7C5a6d5ee56edf4a26ba93f5872dbb9614%7C0%7C0%7C638122163681002644%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=WUQaL2ex8BqHFCNxtrMeOo9NpgPj7iQI6OwFVUeDEIY%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

pakiessling commented 1 year ago

Hi @giovp I improved the tutorials for the QC of Merfish, Xenium and Nanostrings. They make a bit more sense now. Let me know what you think.

pakiessling commented 1 year ago

@LLehner thanks for fixing my spelling 🙈

LLehner commented 1 year ago

Thank you for the improved tutorials and the PR @pakiessling!