scylladb-zpp-2024-javascript-driver / scylladb-javascript-driver

Apache License 2.0
2 stars 0 forks source link

Rust duration type #5

Open adespawn opened 16 hours ago

adespawn commented 16 hours ago

This is a example implementation. The goal is to have some kind of example how to implement datastax custom types. Current approach keeps the data in the rust object, but leaves all the processing that is done in the js part unchanged. As this type is analog to CqlDuration used by the rust driver, there should be a way to create Duration object from CqlDuration, which is implemented.

Both comments about this specific implementation, and general approach are welcomed.

adespawn commented 16 hours ago

It appears draft PR is another feature behind github paywall. For now this is just draft, but all comments are welcome

wprzytula commented 10 hours ago

It appears draft PR is another feature behind github paywall. For now this is just draft, but all comments are welcome

Keep in mind that if we decide to make this repo public, we'll get those features for free.

adespawn commented 6 hours ago

It appears draft PR is another feature behind github paywall. For now this is just draft, but all comments are welcome

Keep in mind that if we decide to make this repo public, we'll get those features for free.

Sure, I think you can change this repo to public.