search

scylladb / argus

Apache License 2.0
4 stars 11 forks source link

Revert "fix(stats.py): Collect worst case comments and investigation" #338

Closed fruch closed 9 months ago

fruch commented 9 months ago

Reverts scylladb/argus#336

this code is breaking the release dashboards:

Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]: [ERROR] <31.210.177.0 - https://argus.scylladb.com/api/v1/release/stats/v2?force=1&limited=0&productVersion=&release=enterprise-2024.1 - >
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]: Traceback (most recent call last):
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]:   File "/home/argus/.cache/pypoetry/virtualenvs/argus-alm-HqUqk8xE-py3.10/lib/python3.10/site-packages/flask/app.py", line 1516, in full_>
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]:     rv = self.dispatch_request()
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]:   File "/home/argus/.cache/pypoetry/virtualenvs/argus-alm-HqUqk8xE-py3.10/lib/python3.10/site-packages/flask/app.py", line 1502, in dispa>
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]:     return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]:   File "/home/argus/app/./argus/backend/service/user.py", line 204, in wrapped_view
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]:     return view(*args, **kwargs)
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]:   File "/home/argus/app/./argus/backend/controller/api.py", line 393, in release_stats_v2
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]:     stats = ReleaseStatsCollector(
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]:   File "/home/argus/app/./argus/backend/service/stats.py", line 362, in collect
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]:     self.release_stats.collect(rows=self.release_rows, limited=limited, force=force)
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]:   File "/home/argus/app/./argus/backend/service/stats.py", line 203, in collect
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]:     stats.collect(limited=limited)
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]:   File "/home/argus/app/./argus/backend/service/stats.py", line 255, in collect
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]:     stats.collect(limited=limited)
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]:   File "/home/argus/app/./argus/backend/service/stats.py", line 332, in collect
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]:     target_run = next(run for run in self.last_runs if run["id"] == worst_case[1]["id"])
Feb 15 13:03:24 ip-10-0-2-112 bash[1100036]: StopIteration