Closed k0machi closed 7 months ago
I find it a bit confusion, that we have display name for the field values i.e. Destroy, or those long titles for backends. it might confuse people later looking it up in jenkins or in logs
I would rather see something like
and so on
Overall it looks good.
Just I think we shouldn't try to prettify the values - cause it would cause confusion, we can add help text to values, but we need to see the actual names.
We can discuss this on today's sync meeting as to how we should deal with pretty values - I think we should have them as the intention of the wizard is to allow people who don't work with SCT to easily queue up a job.
After your requested changes this is how form looks now:
"allow people who don't work with SCT to easily queue up a job"
that doesn't say anything about capital letter, or relabeling things differently the original values
we did talked about help texts that we might want to add to explain things, but I still think we shouldn't be hiding the original names of things, if they are bad names, we should change the in SCT.
Overall it looks good. Just I think we shouldn't try to prettify the values - cause it would cause confusion, we can add help text to values, but we need to see the actual names.
We can discuss this on today's sync meeting as to how we should deal with pretty values - I think we should have them as the intention of the wizard is to allow people who don't work with SCT to easily queue up a job.
After your requested changes this is how form looks now:
backend list is a bit better
I think we can put them side by side,
original name - extra descriptive name
and some cases it's a bit silly, like:
Scylla Version vs. scylla_version
I don't think an extra help is needed in this case.writing both doesn't add anything
we should have both text, when it's adding some more description, otherwise the original value is enough.
Post discussion this is what we have now:
update_db_packages
description name changed, pending a checkbox to hide it if it's emptyStill validation left to do - in particular:
This PR replaces Jenkins rebuild URL with a custom wizard that allows user to execute a job rebuild from inside Argus. The process is split into two distinct phases - fetching and editing job parameters and starting and verifying the job. On the first phase the user is presented with a simple editor (currently only supporting string values) which shows all parameters used for the job (with a toggle to show all parameters for the entire workflow, i.e. empty ones), allowing user to make necessary changes before starting rebuild. On the second phase the job is started and verified until jenkins provides a build number and a job url - at this point the wizard is finished and user is notified of success.
Closes https://github.com/scylladb/qa-tasks/issues/1612