scylladb / argus

Apache License 2.0
4 stars 11 forks source link

feature(argus): Job rebuild via Jenkins API #344

Closed k0machi closed 7 months ago

k0machi commented 8 months ago

This PR replaces Jenkins rebuild URL with a custom wizard that allows user to execute a job rebuild from inside Argus. The process is split into two distinct phases - fetching and editing job parameters and starting and verifying the job. On the first phase the user is presented with a simple editor (currently only supporting string values) which shows all parameters used for the job (with a toggle to show all parameters for the entire workflow, i.e. empty ones), allowing user to make necessary changes before starting rebuild. On the second phase the job is started and verified until jenkins provides a build number and a job url - at this point the wizard is finished and user is notified of success.

Closes https://github.com/scylladb/qa-tasks/issues/1612

k0machi commented 8 months ago

Demo:

https://github.com/scylladb/argus/assets/7761415/5dce6310-d1c3-465a-9166-38851832f9ec

k0machi commented 8 months ago

Demo for the Wizard component:

https://github.com/scylladb/argus/assets/7761415/6eabea0c-1e43-4386-b941-2091337b465e

https://github.com/scylladb/argus/assets/7761415/0f9c9b96-9d21-4f01-9497-8e1548a992d4

fruch commented 8 months ago

I find it a bit confusion, that we have display name for the field values i.e. Destroy, or those long titles for backends. it might confuse people later looking it up in jenkins or in logs

I would rather see something like

and so on

k0machi commented 8 months ago

Overall it looks good.

Just I think we shouldn't try to prettify the values - cause it would cause confusion, we can add help text to values, but we need to see the actual names.

We can discuss this on today's sync meeting as to how we should deal with pretty values - I think we should have them as the intention of the wizard is to allow people who don't work with SCT to easily queue up a job.

After your requested changes this is how form looks now: image

image

fruch commented 8 months ago

"allow people who don't work with SCT to easily queue up a job"

that doesn't say anything about capital letter, or relabeling things differently the original values

we did talked about help texts that we might want to add to explain things, but I still think we shouldn't be hiding the original names of things, if they are bad names, we should change the in SCT.

fruch commented 8 months ago

Overall it looks good. Just I think we shouldn't try to prettify the values - cause it would cause confusion, we can add help text to values, but we need to see the actual names.

We can discuss this on today's sync meeting as to how we should deal with pretty values - I think we should have them as the intention of the wizard is to allow people who don't work with SCT to easily queue up a job.

After your requested changes this is how form looks now: image

image

backend list is a bit better

I think we can put them side by side,

original name - extra descriptive name

and some cases it's a bit silly, like:

Scylla Version vs. scylla_version

I don't think an extra help is needed in this case.writing both doesn't add anything

we should have both text, when it's adding some more description, otherwise the original value is enough.

k0machi commented 8 months ago

Post discussion this is what we have now:

image

Still validation left to do - in particular: