scylladb / argus

Apache License 2.0
4 stars 11 forks source link

feature(argus): Update argus dependencies (Flask 3.0.x) #373

Closed k0machi closed 4 months ago

k0machi commented 5 months ago

This commit relaxes some of the poetry dependencies and additionally updates Flask and other components to their most recent counterparts. Due to certain deprecations, a new ArgusJSONProvider class is now replacing previous serializer for Argus objects.

fruch commented 5 months ago

@k0machi

How do we test such a change ?

I.e. we need a staging env for this one

And initial CI running unittest to the very minimum (pick up GitHub actions and a run of the unittests)

k0machi commented 5 months ago

@k0machi

How do we test such a change ?

I.e. we need a staging env for this one

And initial CI running unittest to the very minimum (pick up GitHub actions and a run of the unittests)

Yes, this one needs it, I'll set up some basic action to test it, just to verify the startup and then I'll proceed with the staging env.

fruch commented 5 months ago

Also what is the reason for this update ? to support python 3.12 ?

I.e. what's the urgency of this ? is it blocking any task you are working on ?

k0machi commented 5 months ago

Also what is the reason for this update ? to support python 3.12 ?

I.e. what's the urgency of this ? is it blocking any task you are working on ?

It's somewhat needed as python packages been ignored for quite a while, e.g. current master won't fully build on latest 3.10 even, some of the stuff I'm doing for #352 might require updating the packages. We can hold this off for now - I'll rebase user-views on current master in case, and meanwhile I can set up a basic github action to verify the environment and simple staging instance with this PR set up.

fruch commented 4 months ago

@k0machi

for this change production would need to change to python3.12 ?

if yes, let's move it to use pyenv, so'll have better control on python versions we need.

k0machi commented 4 months ago

@k0machi

for this change production would need to change to python3.12 ?

if yes, let's move it to use pyenv, so'll have better control on python versions we need.

Production is already using pyenv so no changes needed there aside from installing 3.12 and changing startup script to run that.

And no, 3.12 isn't strictly required, but we might as well upgrade to it.