search

scylladb / argus

Apache License 2.0
4 stars 11 forks source link

feature(Notifications/Comment): Add inline reply to notifications #378

Closed k0machi closed 4 months ago

k0machi commented 5 months ago

This commit adds functionality required to do replies inside notification viewer, skipping the need for going into the main source body and sending a comment there.

Fixes #203

k0machi commented 4 months ago

@soyacz

https://github.com/scylladb/argus/assets/7761415/2341f391-8ee9-4e77-a7e4-f4216809a664

soyacz commented 4 months ago

There's a problem with rendering previous > characters - converted to &gt. Can we do something about it? Maybe we could switch to markdown when using comments to improve the look?

k0machi commented 4 months ago

There's a problem with rendering previous > characters - converted to &gt. Can we do something about it? Maybe we could switch to markdown when using comments to improve the look?

it's to do with who does the sanitization - currently the comment is sanitized before saving by the backend, we could instead sanitize it on the frontend when it is retrieved (since frontend's markdown renderer already does sanitization, this should be simple)

soyacz commented 4 months ago

There's a problem with rendering previous > characters - converted to &gt. Can we do something about it? Maybe we could switch to markdown when using comments to improve the look?

it's to do with who does the sanitization - currently the comment is sanitized before saving by the backend, we could instead sanitize it on the frontend when it is retrieved (since frontend's markdown renderer already does sanitization, this should be simple)

please add a task for it, so this issue does not vanish (or fix here if it is so simple).

k0machi commented 4 months ago

There's a problem with rendering previous > characters - converted to &gt. Can we do something about it? Maybe we could switch to markdown when using comments to improve the look?

it's to do with who does the sanitization - currently the comment is sanitized before saving by the backend, we could instead sanitize it on the frontend when it is retrieved (since frontend's markdown renderer already does sanitization, this should be simple)

please add a task for it, so this issue does not vanish (or fix here if it is so simple).

Done in here, now the reply window will have <>