scylladb / argus

Apache License 2.0
4 stars 11 forks source link

feature(plugins/core): Generic Results #401

Closed soyacz closed 4 months ago

soyacz commented 4 months ago

Introduced generic results: allows clients to send arbitrary tabular data to Argus and show it in Results tab in run view. See docs/generic_results.md for more details.

refs: https://github.com/scylladb/qa-tasks/issues/1244

soyacz commented 4 months ago

Example result: image

soyacz commented 4 months ago

Ok, I made final fixes and I think it's ready for final review.

soyacz commented 4 months ago

still, few bugs. Updated table look slighlty: image

fruch commented 4 months ago

still, few bugs. Updated table look slighlty: image

this looks good, but after you left the sync meeting today we discussed the need of being able to copy this table out, as markdown (for github issues)

soyacz commented 4 months ago

this looks good, but after you left the sync meeting today we discussed the need of being able to copy this table out, as markdown (for github issues)

When selecting whole table (and maybe just a bit more) then I'm capable of putting it to gh (need to remove first line with some styles). Also I was able to paste it to google spreadsheet (with CTRL+SHIFT+V). I could also think of 'copy' button next to each table.

fruch commented 4 months ago

this looks good, but after you left the sync meeting today we discussed the need of being able to copy this table out, as markdown (for github issues)

When selecting whole table (and maybe just a bit more) then I'm capable of putting it to gh (need to remove first line with some styles). Also I was able to paste it to google spreadsheet (with CTRL+SHIFT+V). I could also think of 'copy' button next to each table.

yes, the whole talk started from the copy button we have for the issue lists

soyacz commented 4 months ago

@k0machi can we deploy this PR to staging so I could test it with SCT (and implement couple generic-results sending to Argus in the wild)? Also I'd test client properly then.

soyacz commented 4 months ago

After minor fixes: image