scylladb / argus

Apache License 2.0
4 stars 11 forks source link

improvement(results): add copy button to tables #438

Closed soyacz closed 2 months ago

soyacz commented 2 months ago

Users might want to put resutls into gh issues. Added a copy to markdown button in the corner of all results tables for easy copy it in a way that can be pasted to gh issue. When copy happens, info message appears to give a clear sign about it.

closes: https://github.com/scylladb/argus/issues/421

soyacz commented 2 months ago

example table: image

fruch commented 2 months ago

example table: image

show us the markdown, i.e. paste here as example

soyacz commented 2 months ago
P90 read [ms] P99 read [ms] duration [HH:MM:SS]
Cycle #​0 1.39 2.75 00:30:00
or e.g: P90 read [ms] P99 read [ms] duration [HH:MM:SS]
Cycle #​1 3.43 6.12 00:25:48
Cycle #​2 2.90 5.48 00:18:39
Cycle #​3 2.57 4.53 00:17:12
fruch commented 2 months ago
P90 read [ms] P99 read [ms] duration [HH:MM:SS]
Cycle #​0 1.39 2.75 00:30:00
or e.g: P90 read [ms] P99 read [ms] duration [HH:MM:SS]
Cycle #​1 3.43 6.12 00:25:48
Cycle #​2 2.90 5.48 00:18:39
Cycle #​3 2.57 4.53 00:17:12

Can we add support for coloring ?

See https://github.com/orgs/community/discussions/31570

soyacz commented 2 months ago
I didn't see a way to color whole cells, but values seems to do the job: P90 write [ms] P90 read [ms] P99 write [ms] P99 read [ms] duration [HH:MM:SS]
Cycle #​1 $${\color{green}2.65}$$ $${\color{green}4.15}$$ $${\color{green}5.40}$$ $${\color{red}13.46}$$ $${\color{green}00:33:20}$$
Cycle #​2 $${\color{green}2.29}$$ $${\color{green}3.61}$$ $${\color{green}3.83}$$ $${\color{green}8.47}$$ $${\color{green}00:22:15}$$
Cycle #​3 $${\color{green}2.13}$$ $${\color{green}3.12}$$ $${\color{green}3.28}$$ $${\color{green}6.20}$$ $${\color{green}00:19:38}$$
fruch commented 2 months ago

I didn't see a way to color whole cells, but values seems to do the job:

still better than black and white