search

scylladb / argus

Apache License 2.0
4 stars 11 forks source link

improvement(results): add sending text and screenshots #445

Closed soyacz closed 2 months ago

soyacz commented 2 months ago

improvement(results): add sending text and screenshots

Implemented support for sending text results to argus. Text results are ignored in graphs. If a text result is a link to image it is shown as button which opens given image in a modal (e.g. screenshots). This enables to send screenshots from latency_decorator in SCT.

Also did a bit of refactor around results (moved fetching result tables to ResultsService where fits better.

improvement(screenshots): move to separate component

Moved screenshot modal to separate component to reuse it. Also added 'close by esc' feature.

soyacz commented 2 months ago

This is how it will look in results: image Clicking button opens image in modal - same way as in 'Screenshots' tab.

fruch commented 2 months ago

This is how it will look in results: image Clicking button opens image in modal - same way as in 'Screenshots' tab.

how the copy to markdown would look ?

soyacz commented 2 months ago

how the copy to markdown would look ?

P90 read [ms] P99 read [ms] duration [HH:MM:SS] Overview QA dashboard
Cycle #​1 $${\color{red}5.03}$$ $${\color{green}9.72}$$ $${\color{green}00:28:35}$$ view view