search

scylladb / argus

Apache License 2.0
4 stars 11 forks source link

`Events` tab only showing at most one disruption for any event, even when there are multiple ones #470

Open kbr-scylla opened 1 month ago

kbr-scylla commented 1 month ago

For example let's take https://argus.scylladb.com/test/5cd4bfe3-231b-4f48-99bc-f21ebd1b5efe/runs?additionalRuns%5B%5D=e330a762-61b1-4318-a55c-0b072d4df26e

we have some events there, e.g.: Image the event shows that there was a disruption: disrupt_remove_node_then_add_node at the time of the event (2024-09-10 16:59:35.814)

but from Nemesis tab we can learn that we had multiple disruptions running during this time: Image both disrupt_remove_node_then_add_node and disrupt_create_index started before 2024-09-10 16:59:35.814 and finished after that.

So the event should show both disruptions. I think the implementation assumes there's at most one disruption at any given moment, but SCT has parallel nemeses.

cc @temichus

fruch commented 1 week ago

@kbr-scylla

look inside the event, during_nemesis= actuall show exactly what you are looking

yes the graphical one Argus showing isn't show everything, and should be taking it first from the event information itself (data created by SCT itself), and only then fallback to lookups in the nemesis information.