search

scylladb / argus

Apache License 2.0
4 stars 11 forks source link

improvement(tests): added unit tests for generic results #471

Closed soyacz closed 1 month ago

soyacz commented 1 month ago

Ressurrecting unit-tests for backend. At first, introduced tests for generic results feature. Found few bugs and unneeded code along.

Tests are relying on containerized scylladb cluster (1 node) and reuse it for next tests runs for speed testing. Tests are designed in a way that can be run on the same db (without truncation). Although, there's an unused truncate_all_tables function in case it's needed (it adds few secs of overhead, so better not to use it).

refs: https://github.com/scylladb/argus/issues/468

soyacz commented 1 month ago

LGTM, but I think we still need to clean up old tests / conftest setup

Yes, are there any relevant test cases that could stay?

k0machi commented 1 month ago

LGTM, but I think we still need to clean up old tests / conftest setup

Yes, are there any relevant test cases that could stay?

No, all of them can be removed. As I mentioned before, they all test argus.db module, which is no longer used.

soyacz commented 1 month ago

LGTM, but I think we still need to clean up old tests / conftest setup

Yes, are there any relevant test cases that could stay?

No, all of them can be removed. As I mentioned before, they all test argus.db module, which is no longer used.

Ok, will remove it with other PR that enables tests in CI

soyacz commented 1 month ago

@k0machi did you try running them?

k0machi commented 1 month ago

@k0machi did you try running them?

No, I haven't