search

scylladb / argus

Apache License 2.0
4 stars 11 forks source link

improvement(results): add limit lines to graphs #476

Closed soyacz closed 1 month ago

soyacz commented 1 month ago

Added limit lines to graphs based on best results and validation rules. When creating graphs, for each point limit is calculated and plotted (also visible in the tooltip). Have in mind that limits might differ from ones in "Results" tab as client might ignore rules (which most of our test cases currently do).

closes: https://github.com/scylladb/qa-tasks/issues/1763

soyacz commented 1 month ago

our most complex example*: image

*It won't be visible yet like that on prod, due ValidationRules are not yet applied to latency decorator results or perf simple query results. Also it should vary when new best result appears (or validation rule) but it is not working on my test data as they're imported (and best result date - now - is always greater than SUT date)

soyacz commented 1 month ago

As per discussion today with @fruch , I made it to print only one limit line if 'fixed limit' is set (as it is the same for all the series).

soyacz commented 1 month ago

@fruch @k0machi ping