search

scylladb / argus

Apache License 2.0
4 stars 11 forks source link

Support multiple releases on graphs #489

Closed soyacz closed 1 month ago

soyacz commented 1 month ago

Performance job can run against different scylla release. Because it was not taken into account, graph lines don't differentiate between them making impossible to distinguish different releases.

This commit adds support for mixing different SUT releases in one job and make them visible as separate series on graphs. Additional 'releases' filters were added to easily toggle releases that should be shown.

closes: https://github.com/scylladb/argus/issues/473

soyacz commented 1 month ago

It's not visible that good as I have randomized test data. Note the graph legend on each graph, also there's point shape difference between releases. I left colors the same, but I'm not sure, maybe we should change hue or something to additionally differentiate. Without filters: image

With filter on: image

soyacz commented 1 month ago

@fruch after adjusting to @k0machi feedback and testing it on staging, we decided to merge it - if you have more feedback, let me know.