search

scylladb / argus

Apache License 2.0
4 stars 11 forks source link

feature(graphs): filter data points by date filters #491

Closed soyacz closed 3 weeks ago

soyacz commented 3 weeks ago

In order to narrow down graphs range, date filters were added (by start and end date) with ability to quickly switch between 1,3 and 6 recent months. Last 3 months filter is on by default.

closes: https://github.com/scylladb/argus/issues/474

soyacz commented 3 weeks ago

It's deployed to staging. In general, it looks like this: image

fruch commented 3 weeks ago

It's deployed to staging. In general, it looks like this: image

the layout looks good to me, I think we are using a bit too much coloring for button, it becomes a bit less clear what each one represents.

fruch commented 3 weeks ago

the layout looks good to me, I think we are using a bit too much coloring for button, it becomes a bit less clear what each one represents.

maybe it's time to do a session with a designer, about the UI of those ?

k0machi commented 3 weeks ago

the layout looks good to me, I think we are using a bit too much coloring for button, it becomes a bit less clear what each one represents.

maybe it's time to do a session with a designer, about the UI of those ?

I can look into the UI/UX after this PR, we've discussed some changes in #489.

soyacz commented 3 weeks ago

the layout looks good to me, I think we are using a bit too much coloring for button, it becomes a bit less clear what each one represents.

maybe it's time to do a session with a designer, about the UI of those ?

I can look into the UI/UX after this PR, we've discussed some changes in #489.

Yes, I tried improving UI/UX but I'd rather do it in separate PR to discuss it there out of this context. May I merge it?