search

scylladb / argus

Apache License 2.0
4 stars 11 forks source link

improvement(graphs-ux): graphs filters reorganization #495

Closed soyacz closed 2 weeks ago

soyacz commented 3 weeks ago

Some improvements around graphs filtering: less colors, more organization and labels. image

fruch commented 3 weeks ago

I think the table/column filter separation/titles is a bit unclear for the common user. what we mean by column here is, and what we mean by table, is not exactly intuitive

Maybe "group filters" and "metric filter" ? Or something in that direction?

Also it would be really helpful to have tooltips with a longer description for each button we show there

soyacz commented 3 weeks ago

I think the table/column filter separation/titles is a bit unclear for the common user. what we mean by column here is, and what we mean by table, is not exactly intuitive

Maybe "group filters" and "metric filter" ? Or something in that direction?

I replaced with just Filters and Metrics - after clicking it should become more intuitive.

Also it would be really helpful to have tooltips with a longer description for each button we show there

I validated idea and it doesn't play well with filters. E.g. descriptions: for read - _mgmt_repair_cli - stalls - REACTOR_STALLED is REACTOR_STALLED event counts or table read - _mgmt_repair_cli - latencies has read workload - Scylla-Manger repair. I'd rather see descriptions in graphs itself, under the titles.

soyacz commented 3 weeks ago

image

fruch commented 2 weeks ago

I think the table/column filter separation/titles is a bit unclear for the common user. what we mean by column here is, and what we mean by table, is not exactly intuitive Maybe "group filters" and "metric filter" ? Or something in that direction?

I replaced with just Filters and Metrics - after clicking it should become more intuitive.

Much better

Also it would be really helpful to have tooltips with a longer description for each button we show there

I validated idea and it doesn't play well with filters. E.g. descriptions: for read - _mgmt_repair_cli - stalls - REACTOR_STALLED is REACTOR_STALLED event counts or table read - _mgmt_repair_cli - latencies has read workload - Scylla-Manger repair. I'd rather see descriptions in graphs itself, under the titles.

Logicly I would argue that it's best to be visible when you are selecting what to look at. and not after browsing all of the graphs. nevertheless, we should be able to see those descriptions for anything that has a description.

soyacz commented 2 weeks ago

Logicly I would argue that it's best to be visible when you are selecting what to look at. and not after browsing all of the graphs. nevertheless, we should be able to see those descriptions for anything that has a description.

https://github.com/scylladb/argus/issues/496