scylladb / argus

Apache License 2.0
4 stars 11 forks source link

improvement(views): Highlights View widget #499

Closed soyacz closed 10 hours ago

soyacz commented 1 week ago

Introducing Highlights View Widget that should aid Views with important messages, action items and allow commenting upon them. Originally, intended for performance view dashboard, where important messages and action items are discussed over weekly performance regression tests.

With this widget, users may:

More info in ref issue.

refs: https://github.com/scylladb/argus/issues/485

soyacz commented 1 week ago

Basic view: image

Demo: https://github.com/user-attachments/assets/88b16a20-8d8f-4dc0-9001-43053fe0d57a

soyacz commented 1 week ago

@juliayakovlev can you take a look at the demo and let me know WDYT?

juliayakovlev commented 1 week ago

@juliayakovlev can you take a look at the demo and let me know WDYT?

Lukasz, Where can I see it? I mean not demo, in the Argus. Is it possible?

soyacz commented 1 week ago

@juliayakovlev can you take a look at the demo and let me know WDYT?

Lukasz, Where can I see it? I mean not demo, in the Argus. Is it possible?

Not yet, I didn't deploy it and can't do it on staging as it will modify View on prod. Demo is in linked video.

juliayakovlev commented 1 week ago

Commonly it looks Ok. I just do not understand where it will be located.

soyacz commented 1 week ago

Commonly it looks Ok. I just do not understand where it will be located.

Somewhere around the top of https://argus.scylladb.com/view/performance-regression-tests

soyacz commented 6 days ago

I adjusted the code to support multiple highlight widgets (and it even works).

fruch commented 3 days ago

@soyacz open an issue for adding markup support for highlight and action items

soyacz commented 2 days ago

@k0machi ping

juliayakovlev commented 2 days ago

Maybe it will be good emphasise which kind of error: bad performance or failure/error

k0machi commented 2 days ago

You can rebase to current master as I've merged #503 and then deploy it on staging.