search

scylladb / argus

Apache License 2.0
4 stars 11 forks source link

fix(ViewTypes.js): Add a fallback widget in case of undefined widgets #503

Closed k0machi closed 5 days ago

k0machi commented 1 week ago

This fix addresses a potential issue where a widget created on a newer version of argus will cause an error on an older one when it is loaded from the database.

k0machi commented 6 days ago

need also to add support in View edit

I think it would be for the best if we restrict view editing if an unsupported widget is found in the view definition. Show the error to the user and stop the edit process.

k0machi commented 6 days ago

Demo:

image

soyacz commented 6 days ago

need also to add support in View edit

I think it would be for the best if we restrict view editing if an unsupported widget is found in the view definition. Show the error to the user and stop the edit process.

Cant we make it to be ignored? so we still can edit the others or remove unsupported one?

k0machi commented 6 days ago

need also to add support in View edit

I think it would be for the best if we restrict view editing if an unsupported widget is found in the view definition. Show the error to the user and stop the edit process.

Cant we make it to be ignored? so we still can edit the others or remove unsupported one?

I can add an "Edit anyway" button that will drop the unsupported widget

soyacz commented 6 days ago

need also to add support in View edit

I think it would be for the best if we restrict view editing if an unsupported widget is found in the view definition. Show the error to the user and stop the edit process.

Cant we make it to be ignored? so we still can edit the others or remove unsupported one?

I can add an "Edit anyway" button that will drop the unsupported widget

Yes, if can't just "ignore" it then better to have possibility to fix view in case it's needed.

k0machi commented 6 days ago

@soyacz added the "Edit anyway" button.

image