search

scylladb / care-pet

Care Pet IoT ScyllaDB example
https://care-pet.docs.scylladb.com/
Apache License 2.0
47 stars 28 forks source link

Update theme #16

Closed dgarcia360 closed 3 years ago

dgarcia360 commented 3 years ago

Updates the theme and config file to match other documentation projects.

sitano commented 3 years ago

@dgarcia360 shall we merge it or better wait for @lauranovich review?

dgarcia360 commented 3 years ago

@sitano I'd prefer to get the ok from Laura.

lauranovich commented 3 years ago

Hi Ivan - the rationale is this each project needs a 404.html file so that if the content is not found you get a cute page that says the Scylla Monster ate your page. For consistency, we need all projects to use the same file and not the default one which we had previously.

lauranovich commented 3 years ago

@sitano have you tested it? If so and it builds you can merge it if not, I need to build it and check

sitano commented 3 years ago

@sitano have you tested it? If so and it builds you can merge it if not, I need to build it and check

@lauranovich no, I didn't, don't have time currently. If you have it, please do. It will help me a lot!

lauranovich commented 3 years ago

Screenshot from 2020-09-30 18-19-40 I am not seeing the formatted page when I try to access a page that doesn't exist

dgarcia360 commented 3 years ago

@lauranovich https://github.com/scylladb/scylla-monitoring/pull/1068#issuecomment-701460901

lauranovich commented 3 years ago

@dgarcia360 - https://github.com/scylladb/scylla-monitoring/pull/1068#issuecomment-701933002

dgarcia360 commented 3 years ago

@lauranovich I think this PR can be merged.