scylladb / care-pet

Care Pet IoT ScyllaDB example
https://care-pet.docs.scylladb.com/
Apache License 2.0
48 stars 28 forks source link

Add go-app service to docker compose #50

Closed raoufchebri closed 2 years ago

raoufchebri commented 2 years ago

Adding the go-app service to the docker-compose. Note that the docker-compose builds the go project (migrate, sensor and server). the purpose is to have a base for the developers to connect to the carepet-scylla * nodes.

tzach commented 2 years ago

@raoufchebri if this change require doc changes or README change, please add them as commits to this PR.

guy9 commented 2 years ago

Looks good to me. There is one issue, could be the doc is not updated? When running this according to the documentation here: https://care-pet.docs.scylladb.com/master/getting_started I get:

  1. In this step: cqlsh:carepet> DESCRIBE TABLE pet The documentation describes the table as: CREATE TABLE carepet.pet ( owner_id uuid, pet_id uuid, address text, age int, name text, weight float, PRIMARY KEY (owner_id, pet_id) )

While for me it is: REATE TABLE carepet.pet ( owner_id uuid, pet_id uuid, address text, age int, breed text, chip_id text, color text, gender text, name text, species text, weight float, PRIMARY KEY (owner_id, pet_id) )

raoufchebri commented 2 years ago

Well spotted @guy9. I updated the additional fields.

tzach commented 2 years ago

@guy9 please review the latest version

guy9 commented 2 years ago

Looks good to me, please merge.

tarzanek commented 2 years ago

congrats @raoufchebri ! happy to see the pet clinic flying even on Mac! :-)

FWIW for M1 you might add a comment that image needs to be changed to image: scylladb/scylla-nightly but I know eventually the ARM docker binaries will get to official image: scylladb/scylla, too so it's just a matter of time/blessing from testing team