search

scylladb / cpp-driver

Scylla C/C++ Driver
25 stars 25 forks source link

IT: adjust DCExecutionProfileTests to tablets #101

Open muzarski opened 2 weeks ago

muzarski commented 2 weeks ago

There are two test suites for execution profiles.

ExecutionProfileTest suite uses only 1 dc, while DCExecutionProfile uses 2 of them. Previously, they would both use an LWT insert statement. In this commit, we adjust DCExecutionProfileTest, so it uses non-LWT insert statement.

It looks like LWT statements are executed correctly for a single DC cluster. The DB error is returned for multi-dc clusters (Cannot use LightWeight Transactions for table ...).

dkropachev commented 2 weeks ago

It looks like LWT statements are executed correctly for a single DC cluster. The DB error is returned for multi-dc clusters (Cannot use LightWeight Transactions for table ...).

Can you please look why, it should not be the case, unless there is difference between scylla configuration, scylla version or table creation statement. TBH, this fix does not look like something correct, both cases should test same statements, at max we can skip LWT if tablets are on, but in such case we definitely should test non-LWT query in both cases in addition to LWT.

muzarski commented 2 weeks ago

It looks like LWT statements are executed correctly for a single DC cluster. The DB error is returned for multi-dc clusters (Cannot use LightWeight Transactions for table ...).

Can you please look why, it should not be the case

True, I was confused when I discovered it.

I'll investigate it further then.