scylladb / cpp-rust-driver

API-compatible rewrite of https://github.com/scylladb/cpp-driver as a wrapper for Rust driver.
GNU Lesser General Public License v2.1
11 stars 11 forks source link

Consider unwind vs abort on panic #117

Closed wprzytula closed 1 year ago

wprzytula commented 1 year ago

I can't find any setting that would make panics abort instead of unwinding, which is UB in FFI code; if a stack unwinds into calling C/C++ code, this is UB. As there is at least one panic! and plenty of unwrap()s in the current code (and more panics may be introduced in the future), we should consider switching to safe aborting on panics.

wprzytula commented 1 year ago

@Lorak-mmk