scylladb / cpp-rust-driver

API-compatible rewrite of https://github.com/scylladb/cpp-driver as a wrapper for Rust driver.
GNU Lesser General Public License v2.1
11 stars 11 forks source link

Fix errors detected by a new toolchain #124

Closed wprzytula closed 1 month ago

wprzytula commented 1 month ago

The new toolchain running in the CI detected two problems:

  1. trait CheckSendSync is unused - the warning is silenced now, because the trait exists to assert thread-safety of CassFuture.
  2. std::slice::from_raw_parts was called with invalid pointer - this was because a null pointer was passed a C string in one of the tests; the correspoding argconv routine was changed to handle null pointers properly (by immediately returning None).

Merging this quickly is needed for the CI to pass in other PRs.

Fixes: #123

Pre-review checklist