The new toolchain running in the CI detected two problems:
trait CheckSendSync is unused - the warning is silenced now, because the trait exists to assert thread-safety of CassFuture.
std::slice::from_raw_parts was called with invalid pointer - this was because a null pointer was passed a C string in one of the tests; the correspoding argconv routine was changed to handle null pointers properly (by immediately returning None).
Merging this quickly is needed for the CI to pass in other PRs.
Fixes: #123
Pre-review checklist
[x] I have split my patch into logically separate commits.
[x] All commit messages clearly explain what they change and why.
[x] PR description sums up the changes and reasons why they should be introduced.
[ ] I have enabled appropriate tests in .github/workflows/build.yml in gtest_filter.
[ ] I have enabled appropriate tests in .github/workflows/cassandra.yml in gtest_filter.
The new toolchain running in the CI detected two problems:
trait CheckSendSync
is unused - the warning is silenced now, because the trait exists to assert thread-safety ofCassFuture
.std::slice::from_raw_parts
was called with invalid pointer - this was because a null pointer was passed a C string in one of the tests; the correspoding argconv routine was changed to handle null pointers properly (by immediately returningNone
).Merging this quickly is needed for the CI to pass in other PRs.
Fixes: #123
Pre-review checklist
[ ] I have enabled appropriate tests in.github/workflows/build.yml
ingtest_filter
.[ ] I have enabled appropriate tests in.github/workflows/cassandra.yml
ingtest_filter
.