search

scylladb / cpp-rust-driver

API-compatible rewrite of https://github.com/scylladb/cpp-driver as a wrapper for Rust driver.
GNU Lesser General Public License v2.1
11 stars 11 forks source link

Compile on Windows #130

Open mykaul opened 3 weeks ago

mykaul commented 3 weeks ago

We should use GH action and make sure this compiles on Windows as well.

Lorak-mmk commented 2 weeks ago

Our fork of original cpp-driver didn't support Windows afaik so it's not a compatibility issue. Is there a specific reason for this change / client request etc? Drivers are usually used server-side which is dominated by linux. Is there any other driver apart from python-driver where we test Windows in CI? I have very bad memories from trying to use windows in CI for C++ projetcs, and in general from trying to maintain Windows compatibility. While this project is mostly Rust there is still a fair share of C++ code. I fear the moment when we would need to debug and fix some windows-specific issue...

mykaul commented 2 weeks ago

Customer request. See PRs on the previous CPP driver.

Lorak-mmk commented 2 weeks ago

Do you know the use case of this customer? Do they use Windows Server for Scylla clients?

Lorak-mmk commented 2 weeks ago

Scylla itself doesn't support Windows (but that would be a "fun" hackathon project :D ), so it can only be an issue in environment where some servers run Linux and some run Windows Server - I'm curious why that would be the case.

mykaul commented 2 weeks ago

Scylla itself doesn't support Windows (but that would be a "fun" hackathon project :D ), so it can only be an issue in environment where some servers run Linux and some run Windows Server - I'm curious why that would be the case.

Why won't the client run on Windows?

mykaul commented 1 week ago

See https://github.com/scylladb/cpp-driver/pull/83 for ref from the old driver.

Lorak-mmk commented 1 week ago

Scylla itself doesn't support Windows (but that would be a "fun" hackathon project :D ), so it can only be an issue in environment where some servers run Linux and some run Windows Server - I'm curious why that would be the case.

Why won't the client run on Windows?

You mean the end-application that runs on some untrusted users PC? Because that would require such user to have access to the database.

mykaul commented 1 week ago

Scylla itself doesn't support Windows (but that would be a "fun" hackathon project :D ), so it can only be an issue in environment where some servers run Linux and some run Windows Server - I'm curious why that would be the case.

Why won't the client run on Windows?

You mean the end-application that runs on some untrusted users PC? Because that would require such user to have access to the database.

I have no idea if it's trusted or not. It's not different than a Linux client. It's a different OS, that some people actually use - and may need access to Scylla from it. Probably some Windows Server edition.