rust: Replace `From<&T> for TT` impls with `T::to_TT` methods

scylladb / cpp-rust-driver

API-compatible rewrite of https://github.com/scylladb/cpp-driver as a wrapper for Rust driver.

GNU Lesser General Public License v2.1

16 stars 11 forks source link

Open muzarski opened 2 months ago

muzarski commented 2 months ago

We should not implement From<> trait for borrowed types. See https://rust-lang.github.io/api-guidelines/naming.html#ad-hoc-conversions-follow-as_-to_-into_-conventions-c-conv. All appearances of From<&T> for TT should be replaced with T::to_TT methods.