search

scylladb / cpp-rust-driver

API-compatible rewrite of https://github.com/scylladb/cpp-driver as a wrapper for Rust driver.
GNU Lesser General Public License v2.1
16 stars 11 forks source link

Ensure cpp-rust-driver handles zero-token nodes properly #203

Open dkropachev opened 3 months ago

dkropachev commented 3 months ago

PR#19684 brings possibility of having nodes coordinator-only nodes (or zero-token nodes). These types of nodes are going to be supported only in RAFT.

Such nodes, despite being registered in the cluster, do not handle any queries and should be excluded from query routing. This feature is already present in cassandra, but not merged into scylla yet, so we might want to start testing it on our drivers with cassandra first.

Difference between cassandra and scylla implementation

Major difference is that these nodes are absent from system.peers and system.peers_v2 in cassandra, while in scylla implementation these nodes are going to be present there.

Due to this fact we will need to test Apache and datastax drivers against scylla as well.

Approx. Testing plan

Regular cluster

  1. Spin up a cluster with 3 nodes
  2. Join one additional node in zero-token mode, by setting join_ring to false in it's configuration, or adding -Dcassandra.join_ring=false to cli (cassandra only).
  3. Make sure that drivers works as expected and do not throw any errors while reading schema with this node being in the cluster
  4. Make sure that drivers works as expected and do not throw any errors while processing topology events (if these events issues) when such node joins/leaves cluster.
  5. Make sure that zero-token node does not participate in the routing
  6. Test if driver works properly if only connection point provided is zero-token node
  7. Ensure that at no point driver throw error or warning caused by zero-token node presence.

Cluster that starts with zero-token node

  1. Start single node cluster with join_ring=false
  2. Connect to it, to make sure that driver session is created and every query end up in no host available error.
  3. Populate cluster with 3 more nodes
  4. Make sure that driver can execute queries
  5. Ensure that at no point driver throw error or warning.

Links

Original umbrella issue in scylladb/scylladb repo: https://github.com/scylladb/scylladb/issues/19693 Core issue to bring join_ring option into scylla: https://github.com/scylladb/scylladb/issues/6527 PR that brings this feature in https://github.com/scylladb/scylladb/pull/19684

Lorak-mmk commented 3 months ago

We probably won't be implementing it here, but in rust-driver (and thus in cpp-rust-driver). Do we need this issuse?

roydahan commented 1 week ago

Moved to cpp-rust-driver and reopening to make sure we have it there after rust-driver implementation.