search

scylladb / cpp-rust-driver

API-compatible rewrite of https://github.com/scylladb/cpp-driver as a wrapper for Rust driver.
GNU Lesser General Public License v2.1
16 stars 11 forks source link

Implement CassDataType, CassUserType, CassTuple #60

Closed Lorak-mmk closed 2 years ago

Lorak-mmk commented 2 years ago

Based on https://github.com/hackathon-rust-cpp/cpp-rust-driver/pull/58 Implements CassDataType Implements CassUserType, CassTuple and all bindings related to them, using new macros.

Lorak-mmk commented 2 years ago

@piodul I fixed all issues pointed by you. Could you check if current tuple implementation is consistent with cpp-driver? I don't trust myself - I was sure it was correct before, but today it turned out to be wrong.

haaawk commented 2 years ago

@piodul could you help @Lorak-mmk with tuples question?

piodul commented 2 years ago

@Lorak-mmk I'm not too familiar with the cpp-driver's logic, but from what I managed to understand, your current logic checks out. In the future, it would be worthwhile to write differential tests in order to help enforce the same behavior as in the cpp-driver.

Lorak-mmk commented 2 years ago

Fixed. I had to use global variable to handle cass_tuple_data_type for tuples created by cass_tuple_new @piodul