Closed Gor027 closed 1 year ago
Interestingly, BasicsTests.Integration_Cassandra_Timestamps failed in the latest run (https://github.com/scylladb/cpp-rust-driver/actions/runs/2890498078/attempts/1). It looks like it's a bit time-sensitive and might be flaky on slower machines (such as GitHub Actions workers).
@Gor027 Have you seen this before?
Yes, I was aware of it. Maybe we can manually increase the acceptable difference in the test, to avoid failures because of slow machines?
The Integration_Cassandra_Timestamps
will be fixed in a follow-up PR as agreed.
Pre-review checklist
.github/workflows/build.yaml
ingtest_filter
.This PR is dependent on #68.
Adds necessary implementation to pass all
CassandraTypesTests
excludingUDT
tests as it requires an implementation to get cluster schema metadata, so it will be done in another PR. Tests are modified to properly iterate over collections to check their values and size. AsCassandraTypesTests
tests collections with all possible types, overall208
tests are enabled. Only tests forDecimal
andVarint
types are disabled, asinvoke_binder_maker_macro_with_type
is not yet implemented forDecimal
type andcass_value_get_bytes
is not implemented forVarint
. The latter should be implemented for all types, however, it requires the rust driver to return raw bytes of values instead ofCqlValue
.