Closed muzarski closed 9 months ago
v2:
src/distribution.rs
insteadDistributionParser
trait (with its implementations)DistributionParser
implementations to specific DistributionFactories
.DistributionParser
implementations to distribution factoriesDistributionFactory::create
from Arc<dyn Distribution>
to Box<dyn Distribution>
. Some of the distributions are not shared (Box
should be used), when at the same time there is a distribution that will be shared across multiple tokio tasks (Arc
). It's much easier to convert Box<dyn Object>
to Arc<dyn Object>
(.into()
), than the other way around.-pop dist
parameter) as distribution which RowGenerator
samples pk_seeds
from-col
option parameters in the runtime, including:-col n
or -col names
parameters)RowGenerator
samples the size of the blob data that is going to be generated from this distribution) based on user-provided distribution (-col size
parameter)v3:
RowGeneratorFactory::settings
field.v4:
DistributionParam
, using SimpleParam<Box<dyn DistributionFactory>>
insteadParsable
for Box<dyn DistributionFactory>
(moved parsing logic from DistributionParam
)SimpleParam
struct by additional_desc
fieldv5: fixed review comments, ready to merge
Changes
Param
trait, by extracting most of the common logic to the wrapping typeDistributionParam
-col
option-pop
option