search

scylladb / gocql

Package gocql implements a fast and robust ScyllaDB client for the Go programming language.
https://docs.scylladb.com/stable/using-scylla/drivers/cql-drivers/scylla-go-driver.html
BSD 3-Clause "New" or "Revised" License
181 stars 57 forks source link

Fix cowHostList can't have hosts with same `ConnectAddress` #182

Closed dkropachev closed 4 months ago

dkropachev commented 4 months ago

cowHostList uses HostInfo.Equal to confirm host uniqueness, which relies on ConnectAddress.Equal, which does not allow to have different hosts with same ConnectAddress.

Which leads to https://github.com/gocql/gocql/issues/1757. Closes #1757

dkropachev commented 4 months ago

Should go to https://github.com/gocql/gocql

mykaul commented 4 months ago

Should go to https://github.com/gocql/gocql

Could go - but if that repo is not responsive ( https://github.com/gocql/gocql/graphs/commit-activity ), we should fix it here.

roydahan commented 4 months ago

@dkropachev please reopen it. The upstream repo is not active (last commit was 10 months ago). You can leave the PR open there as well, but we will probably review and merge here anyway.

dkropachev commented 4 months ago

@roydahan , @mykaul , done up here