search

scylladb / gocql

Package gocql implements a fast and robust ScyllaDB client for the Go programming language.
https://docs.scylladb.com/stable/using-scylla/drivers/cql-drivers/scylla-go-driver.html
BSD 3-Clause "New" or "Revised" License
181 stars 57 forks source link

Fix cowHostList can't have hosts with same `ConnectAddress` #185

Closed dkropachev closed 4 months ago

dkropachev commented 4 months ago

Addresses issue from gocql/gocql

Reopening of a https://github.com/scylladb/gocql/pull/182

Problem

cowHostList uses HostInfo.Equal to confirm host uniqueness, which relies on ConnectAddress.Equal. As result cowHostList does not allow to have different hosts with same ConnectAddress.

It breaks cases like accessing cluster via tcp or ssl proxy

dkropachev commented 4 months ago

@sylwiaszunejko , I can't make pipeline to pass, starting container is failing, it has nothing to do with this PR

sylwiaszunejko commented 4 months ago

@dkropachev please rebase to master and the pipeline should pass then