search

scylladb / gocql

Package gocql implements a fast and robust ScyllaDB client for the Go programming language.
https://docs.scylladb.com/stable/using-scylla/drivers/cql-drivers/scylla-go-driver.html
BSD 3-Clause "New" or "Revised" License
169 stars 47 forks source link

Bump scylla version to 5.4.6 and use fixed version for all of the nodes #187

Closed sylwiaszunejko closed 1 month ago

sylwiaszunejko commented 1 month ago

Previously scylla integration tests used scylla 5.2.9 and tablet tests used scylladb/scylla-nightly.

This PR changes scylla version to scylladb/scylla:5.4.6 for node used to integration test and to fixed version of scylla-nightly for tablet tests.

sylwiaszunejko commented 1 month ago

The CI does not work. It looks like there is a problem with the scylla.yaml file (that is the main difference between node1 and the rest of nodes) when using scylla version higher than 5.2.x https://github.com/scylladb/gocql/blob/master/testdata/config/scylla.yaml

dkropachev commented 1 month ago

@sylwiaszunejko , in general I think it is bad idea to run tests on dynamic tags, better pick something static and update it time to time

sylwiaszunejko commented 1 month ago

@sylwiaszunejko , in general I think it is bad idea to run tests on dynamic tags, better pick something static and update it time to time

I agree after I saw the logs from failing container I agree we should be more thoughtful about changing these versions.

sylwiaszunejko commented 1 month ago

CI is failing due to merging #188 by mistake. After #189 is merged CI should work fine here.

sylwiaszunejko commented 1 month ago

CI works now, @avelanarius could you look at it?