search

scylladb / gocql

Package gocql implements a fast and robust ScyllaDB client for the Go programming language.
https://docs.scylladb.com/stable/using-scylla/drivers/cql-drivers/scylla-go-driver.html
BSD 3-Clause "New" or "Revised" License
181 stars 57 forks source link

Revert "Print out logs of failed container" #189

Closed sylwiaszunejko closed 4 months ago

sylwiaszunejko commented 4 months ago

Reverts scylladb/gocql#188

This change not only prints out the logs if container is unhealthy but also exits and manage to not run the tests when there is nothing wrong with the containers.

mykaul commented 4 months ago

Please add a reason for reverting a commit in the revert commit message.

sylwiaszunejko commented 4 months ago

Please add a reason for reverting a commit in the revert commit message.

Done, sorry for merging that without being 100% sure that it is right and creating this whole situation

mykaul commented 4 months ago

Please add a reason for reverting a commit in the revert commit message.

Done, sorry for merging that without being 100% sure that it is right and creating this whole situation

No worries - this is not the issue at all. The issue is that it'd be great to know why we reverted a commit.

sylwiaszunejko commented 4 months ago

I added more detailed commit message

dkropachev commented 4 months ago

@sylwiaszunejko , @mykaul, i should have kept that PR as draft, sorry.

Let's better merge this one, it will fix the issue but keep printing logs on error

sylwiaszunejko commented 4 months ago

@dkropachev I think it would be better to first merge this, then merge #187 and when the CI will be fixed we could add extra logging, because now CI on #190 won't pass

dkropachev commented 4 months ago

@dkropachev I think it would be better to first merge this, then merge #187 and when the CI will be fixed we could add extra logging, because now CI on #190 won't pass

But it won't pass because test is running on an image that don't support tablets:

 error: the argument ('tablets') for option '--experimental-features' is invalid
mykaul commented 4 months ago

@dkropachev I think it would be better to first merge this, then merge #187 and when the CI will be fixed we could add extra logging, because now CI on #190 won't pass

But it won't pass because test is running on an image that don't support tablets:

 error: the argument ('tablets') for option '--experimental-features' is invalid

And it's not going to be needed when 6.0 comes out (soon! soon!)