search

scylladb / kafka-connect-scylladb

Kafka Connect Scylladb Sink
Apache License 2.0
42 stars 22 forks source link

Documentation | Deletes Enabled Support #1

Closed patitapaban19 closed 4 years ago

patitapaban19 commented 4 years ago

This PR includes the following :

  1. Connector Documentation(Quickstart, README, Config)
  2. Feature : Support for deletes.enabled
tarzanek commented 4 years ago

lgtm other than the comments I've mentioned, good stuff, thank you @patitapaban19 !

patitapaban19 commented 4 years ago

@tarzanek have resolved the comments provided by you.

tarzanek commented 4 years ago

lgtm, I think this can be merged @mailmahee (unless you want to wait for the small nitpicks, but the core looks good)

tarzanek commented 4 years ago

@mailmahee lgtm, do you want to merge or another pair of eyes?

mailmahee commented 4 years ago

LGTM - Thanks @fahadhasher @patitapaban19